import/export Taxonomy API functions #1
Conversation
ChrisChV
force-pushed
the
chris/taxonomy-import-export
branch
from
c0e5a48 to
ebda011
Compare
pomegranited
left a comment
pomegranited
left a comment
There was a problem hiding this comment.
This is looking better, thank you @ChrisChV ! Couple more changes requested, but once they're resolved, this should be good to go.
openedx_tagging/core/tagging/api.py
Outdated
| f"Invalid JSON format: Missing '{key}' on a tag ({tag})" | ||
| ) | ||
| ) | ||
| resync_tags() |
There was a problem hiding this comment.
I added an optional parameter to resync_tags which will speed up this call:
| resync_tags() | |
| resync_tags(ObjectTag.objects.filter(taxonomy=taxonomy)) |
You'll need to merge the latest changes from openedx#57 over here to use it though.
ChrisChV
force-pushed
the
chris/taxonomy-import-export
branch
from
ebda011 to
455e783
Compare
pomegranited
force-pushed
the
jill/taxonomy-api
branch
from
198bea7 to
1551cea
Compare
pomegranited
left a comment
pomegranited
left a comment
There was a problem hiding this comment.
@ChrisChV This branch looks great, thank you!
I've squashed and rebased openedx#57 and am hoping that will be merged tomorrow.. so I think you can wait until that's merged and resurrect openedx#58, moving these changes over there?
Sorry for all the changes on my branch.. it's hard to work in parallel like this, but was the best use of time I think.
👍
- I tested this by running the tests on my local machine and ensuring they cover all the code.
- I read through the code carefully and checked that it covers the required functionality.
-
I checked for accessibility issuesN/A - Includes documentation
- Commit structure follows OEP-0051
pomegranited
force-pushed
the
jill/taxonomy-api
branch
from
1551cea to
ac388bb
Compare
Also: * Adds compile-requirements make target and updates (without upgrading) the requirements, which pulled in some other requirements, since it's been a while since they were compiled. * Adds ddt as a test dependency. * Replaces the placeholder TagContent class, and squashes migrations down to a single file * use the openedx_learning.lib multi-collation char and text fields
Also: * Adds rules requirement and app settings to enable it * Adds mock to test requirements, so we can test system taxonomy rules * ADR: Clarifies that rules will be enforced in the views, not the model or APIs
Tests are failing in openedx on sqlite.
ChrisChV
force-pushed
the
chris/taxonomy-import-export
branch
from
a043b41 to
e5b1698
Compare
|
Closed in favor of openedx#64 |
Description
Implements import_tags and export_tags functions
Supporting information
Temporal PR until openedx#57 will merged
Testing instructions