[SE-4482] Allow delete course content in Studio only for admin users#362
Closed
Skchoudhary wants to merge 7 commits intoesme-oxford-release/koa.3from
Closed
Conversation
added 6 commits
June 17, 2021 19:35
nizarmah
reviewed
Jun 21, 2021
nizarmah
left a comment
nizarmah
left a comment
There was a problem hiding this comment.
👍
- I tested this by following the testing instructions
- I read through the code
-
I checked for accessibility issues -
Includes documentation -
I made sure any change in configuration variables is reflected in the corresponding client'sconfiguration-securerepository.
nizarmah
approved these changes
Jun 21, 2021
(cherry picked from commit 366f2f6)
nizarmah
force-pushed
the
se-4482-allow-delete-in-studio-only-for-admin-oxford-koa.3
branch
from
562b6fa to
a3426cd
Compare
|
Closing this pull request since I'm going to be cherry-picking an identical squashed commit into the branch instead. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR and a check to show/hide the delete button on the course content in Studio. With these changes, the delete button is only visible to the admin user one with the
CourseInstructorrole only and will not be visible to theCourseStaffrole users.Course Outline view for the user when it has admin access to the course
Course Outline view for the user when it has staff access to the course
Supporting information
JIRA Ticket: SE-4482
Testing instructions
FYI: This testing instruction is for the sandbox deployed against this PR
staff@example.comonhttps://studio.pr360.sandbox.opencraft.hosting/.verified@example.comas the staff for the courseverified@example.comon the studio pageverified@example.comshould not be able to see the delete button on the course outline page.Reviewers