[FAL-2076] Cherry-pick celery fixes on Koa.3 #367
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Update celery routing - Used routing function instead of class - Move task queues dictionary to Django settings - Removed routing_key parameter - Refactored routing for singleton celery instantiation Co-authored-by: Awais Qureshi <awais.qureshi@arbisoft.com> (cherry picked from commit e3b4d23)
(cherry picked from commit d1060d2)
|
👍 LGTM |
The required `set_code_owner_attribute` decorator was introduced in v3.12.0, therefore we need to bump the dependency. (cherry picked from commit f52b84e)
|
@gabor-boros, @pomegranited edx@f52b84e was missing from this PR. I've just pushed it. And trying to re-provision failed app-servers. |
Author
|
This change doesn't seem to be required for Koa, so I'm closing this. |
pomegranited
changed the title
Makes HIGH_PRIORITY_QUEUE a derived setting, which allows HEARTBEAT_CELERY_ROUTING_KEY to use the correct config variant default. (cherry picked from commit 2a9067a)
pomegranited
force-pushed
the
jill/celery-fixes-koa.3
branch
from
6efcb81 to
b8fecc1
Compare
Author
|
Reopened this so that the celerybeat changes from SE-4304 can also be merged into our release branch. CC @gabor-boros |
pomegranited
changed the title
gabor-boros
approved these changes
Jul 7, 2021
|
👍 🎉
|
dliberat
pushed a commit
that referenced
this pull request
Jul 8, 2021
[FAL-2076] Cherry-pick celery fixes on Koa.3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-picks the following PRs from upstream koa.master:
Testing instructions
Sandbox (provisioning):
Ensure that the sandbox provisions, and the appserver's extended celery checks work as expected.
Author Notes & Concerns
Reviewer