feat: adds CELERY_BROKER_TRANSPORT_OPTIONS #410
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
which can be configured from the lms/studio environment refactor: raise ImproperlyConfigured on TypeError Signed-off-by: Gabor Boros <gabor.brs@gmail.com>
pomegranited
approved these changes
Sep 30, 2021
pomegranited
left a comment
pomegranited
left a comment
There was a problem hiding this comment.
👍
- I tested this on a koa sandbox using the same procedure described on https://github.com/edx/edx-platform/pull/28849#pullrequestreview-767349643
- I checked the code against the original https://github.com/edx/edx-platform/pull/28849
|
@gabor-boros Your upstream change has been merged 🎉 so this one can be merged too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Cherry-pick of https://github.com/edx/edx-platform/pull/28849
The release of Redis 6 introduced the ability to share this service among multiple accounts, securing the access to specific keys using a username/password and ACLs. Celery uses kombu to provide Redis brokering for the message queues, but kombu was missing a couple of key enhancements to support multi-tenant redis.
This PR allows to configure the broker transport options to enjoy the benefits of the above-mentioned updates.
Supporting information
OpenCraft wants to use multi-tenant Redis for their shared hosting service, so we can stop maintaining RabbitMQ.
Deadline
None
Other information
The initial PR that partially contained these changes: https://github.com/edx/edx-platform/pull/28020
Reviewers