[SE-4650] feat: Add course-wide custom scripts #424
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabor-boros
changed the title
nizarmah
suggested changes
Oct 4, 2021
nizarmah
left a comment
nizarmah
left a comment
There was a problem hiding this comment.
@gabor-boros 👍🏼
- I tested this by following the testing instructions you described
- I ensured the cherry-picked commit references the initial commit
@gabor-boros can you please rebase your branch and cherry-pick the commit again using -x so that the reference to the upstream commit is also included?
Imlements OEP-15 by adding two fields to the course settings: - Course-wide Custom JS - Course-wide Custom CSS The resources defined in these fields will be rendered in all course pages. Rebase b6cb629..0578e1c4c6 onto b6cb629: - Add course-wide resources to API for MFE use - Revert "Add course-wide resources to API for MFE use" reverts commit 53648dcf0afe3cd171c9dc2eb5e56b871b2bcfb2 cherry picked from commit e482b85 Signed-off-by: Gabor Boros <gabor.brs@gmail.com>
gabor-boros
force-pushed
the
gabor/cherry-pick-oep-15
branch
from
0003f35 to
1f7bad2
Compare
Author
|
@nizarmah the commit is amended. |
nizarmah
approved these changes
Oct 4, 2021
nizarmah
left a comment
nizarmah
left a comment
There was a problem hiding this comment.
@gabor-boros 👍🏼
- I tested this by following the testing instructions you described
- I ensured the cherry-picked commit references the initial commit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of https://github.com/edx/edx-platform/pull/28411
Imlements OEP-15 by adding two fields to the course settings:
The resources defined in these fields will be rendered in all course pages.
Rebase b6cb629..0578e1c4c6 onto b6cb629:
Signed-off-by: Gabor Boros gabor.brs@gmail.com
Testing instructions