BB-4977: feat: Compile JS translations for Arabic#432
Conversation
|
@swalladge Were the translation commits cherry-picked into the Lilac branches? If so, I'll open a pull request against those branches as well. |
|
👍
|
|
@giovannicimolin the branch has already been prepared, so no. Could you open a PR against opencraft-release/lilac.2 with this as part of BB-4977? We'll need to do this with anything new between now and when we finish the lilac upgrade. |
|
@swalladge I'll create a follow-up for this. BTW, I was not aware of the deadlines for pushing things to the "old" Koa branches before the creation of new ones, and we recently merged other things for this same client in the Koa common branch. Can you schedule another pass on the common branches before scheduling all upgrades? Or should I do that during this client's upgrade? |
Sure I can take another look 👍 Let me know if there are any particular PRs you don't want missed too. :) |
|
@giovannicimolin , actually, I don't see even this PR in our standard query for code drift. Could you check that out? I don't really understand why it's not displaying there, unless this was upstreamed? 🤔 |
|
@swalladge The link you posted is for the The related commits are showing up for me: I've scheduled https://tasks.opencraft.com/browse/BB-5053 to check up on the translations before doing the upgrade. |
|
@giovannicimolin aah my bad, sorry, not sure how I mixed that up. In that case, it's fine - preparing our lilac release for edx-platform is happening in BB-4877, and that hasn't been done yet. :) Should be good here. |
|
@swalladge That's perfect then, thanks for the update! :) |


The Arabic translations were present but not compiled into the corresponding JS files.
@Cup0fCoffee This is ready for review.