Skip to content

BB-4977: feat: Compile JS translations for Arabic#432

Merged
giovannicimolin merged 1 commit intoopencraft-release/koa.3from
giovanni/bb-4977-compile-ar-translations
Oct 18, 2021
Merged

BB-4977: feat: Compile JS translations for Arabic#432
giovannicimolin merged 1 commit intoopencraft-release/koa.3from
giovanni/bb-4977-compile-ar-translations

Conversation

@giovannicimolin
Copy link

The Arabic translations were present but not compiled into the corresponding JS files.

@Cup0fCoffee This is ready for review.

@giovannicimolin
Copy link
Author

@swalladge Were the translation commits cherry-picked into the Lilac branches? If so, I'll open a pull request against those branches as well.

@Cup0fCoffee
Copy link
Member

👍

  • I tested this: checked out branch, started local lms and checked that the relevant translations are present, without having to recompile the js internationalization. Also checked that recompiling js translations doesn't produce any changes for ar language.
  • I read through the code
  • [na] I checked for accessibility issues
  • [na] Includes documentation
  • [na] I made sure any change in configuration variables is reflected in the corresponding client's configuration-secure repository.

@giovannicimolin giovannicimolin merged commit 027c389 into opencraft-release/koa.3 Oct 18, 2021
@giovannicimolin giovannicimolin deleted the giovanni/bb-4977-compile-ar-translations branch October 18, 2021 17:06
@samuelallan72
Copy link
Member

@giovannicimolin the branch has already been prepared, so no. Could you open a PR against opencraft-release/lilac.2 with this as part of BB-4977? We'll need to do this with anything new between now and when we finish the lilac upgrade.

@giovannicimolin
Copy link
Author

@swalladge I'll create a follow-up for this.

BTW, I was not aware of the deadlines for pushing things to the "old" Koa branches before the creation of new ones, and we recently merged other things for this same client in the Koa common branch. Can you schedule another pass on the common branches before scheduling all upgrades? Or should I do that during this client's upgrade?

@samuelallan72
Copy link
Member

@giovannicimolin

Can you schedule another pass on the common branches before scheduling all upgrades?

Sure I can take another look 👍 Let me know if there are any particular PRs you don't want missed too. :)

@samuelallan72
Copy link
Member

@giovannicimolin , actually, I don't see even this PR in our standard query for code drift. Could you check that out? I don't really understand why it's not displaying there, unless this was upstreamed? 🤔

@giovannicimolin
Copy link
Author

giovannicimolin commented Oct 21, 2021

@swalladge The link you posted is for the configuration branch, I've used this one for edx-platform.

The related commits are showing up for me:
image

And then the current PR:
image


I've scheduled https://tasks.opencraft.com/browse/BB-5053 to check up on the translations before doing the upgrade.

@samuelallan72
Copy link
Member

@giovannicimolin aah my bad, sorry, not sure how I mixed that up. In that case, it's fine - preparing our lilac release for edx-platform is happening in BB-4877, and that hasn't been done yet. :) Should be good here.

@giovannicimolin
Copy link
Author

@swalladge That's perfect then, thanks for the update! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants