[SE-4631] add CCX ID to generated filename prefixes (#27028) #435
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkulkark
approved these changes
Nov 2, 2021
Member
pkulkark
left a comment
pkulkark
left a comment
There was a problem hiding this comment.
LGTM 👍
- I tested this: verified that the required ccx prefix is added to the filename as described in the testing instructions
- I read through the code
-
I checked for accessibilityN/A -
Incudes documentationN/A
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the backport of https://github.com/edx/edx-platform/pull/27028.
This pull requests backport a feature to include CCX course IDs in the generated course filenames used for downloading reports, etc.
The suffix appended to the generated filename prefix is following the
<separator>_ccx_<ccx id>pattern, to ensure unique filename generation per ccx - previously all CCX courses were downloaded with the same name.Dependencies: None
Screenshots:
Sandbox URL: TBD
Merge deadline: None
Testing instructions: