[BB-5429] Added date configuration to Schedule & Details settings page#458
Merged
Cup0fCoffee merged 1 commit intoopencraft-release/lilac.2from Feb 10, 2022
Conversation
Member
Author
|
👍
@jbcurtin you need to approve this PR I have opened this to save some time, hope you don't mind it :) and I am really sorry to close the previous PR it was against the wrong branch 🙇🏾 |
|
LGTM 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds the ability to configure Schedule & Details settings page with the ability to show
dd/mm/yyyyformat. Default setting maintains existing behavior and doesn't introduce anything new.Why:
Some areas of the world operate with the day-first:
dd/mm/yyyyrather thanmm/dd/yyyy.JIRA tickets: BB-5329
Discussions: Link to any public dicussions about this PR or the design/architecture. Otherwise omit this.Dependencies: NoneScreenshots:
Sandbox URL: TBD - sandbox is being provisioned.Merge deadline: None
Testing instructions
make dev.shell.studioFeaturesaddSCHEDULE_DETAIL_FORMAT: 'DD/MM/YYYY'FEATURES: ... SCHEDULE_DETAIL_FORMAT: 'DD/MM/YYYY' ...make dev.restart-devserver.studioDD/MM/YYYYAuthor notes and concerns:
Reviewers