Skip to content

[BB-5429] Added date configuration to Schedule & Details settings page#458

Merged
Cup0fCoffee merged 1 commit intoopencraft-release/lilac.2from
jbcurtin/BB-5429-date-configuration-opencraft-lilac.2
Feb 10, 2022
Merged

[BB-5429] Added date configuration to Schedule & Details settings page#458
Cup0fCoffee merged 1 commit intoopencraft-release/lilac.2from
jbcurtin/BB-5429-date-configuration-opencraft-lilac.2

Conversation

@farhaanbukhsh
Copy link
Member

@farhaanbukhsh farhaanbukhsh commented Feb 8, 2022

Description

Adds the ability to configure Schedule & Details settings page with the ability to show dd/mm/yyyy format. Default setting maintains existing behavior and doesn't introduce anything new.
Why:
Some areas of the world operate with the day-first: dd/mm/yyyy rather than mm/dd/yyyy.

JIRA tickets: BB-5329

Discussions: Link to any public dicussions about this PR or the design/architecture. Otherwise omit this.

Dependencies: None

Screenshots:

image

Sandbox URL: TBD - sandbox is being provisioned.

Merge deadline: None

Testing instructions

  • Initialize lilac devstack to use branch
  • Look at the studio --> course(Demo Course) --> settings --> Schedule and Details
  • Go under the Course Schedule section and you will see the date format is MM/DD/YYYY
  • Now drop in the studio shell make dev.shell.studio
  • Edit /edx/etc/studio.yml and under Features add SCHEDULE_DETAIL_FORMAT: 'DD/MM/YYYY'

FEATURES: ... SCHEDULE_DETAIL_FORMAT: 'DD/MM/YYYY' ...

  • Restart studio make dev.restart-devserver.studio
  • Now check the page again you will see the date format has changed to DD/MM/YYYY

Author notes and concerns:

Reviewers

@farhaanbukhsh
Copy link
Member Author

👍

  • ✅ I tested this, on the devstack with testing instructions
  • ✅ I read through the code
  • ❌ I checked for accessibility issues
  • ❌ Includes documentation
  • ❌ I made sure any change in configuration variables is reflected in the corresponding client's configuration-secure repository.

@jbcurtin you need to approve this PR I have opened this to save some time, hope you don't mind it :) and I am really sorry to close the previous PR it was against the wrong branch 🙇🏾

@jbcurtin
Copy link

jbcurtin commented Feb 8, 2022

LGTM 👍

@Cup0fCoffee Cup0fCoffee merged commit a20514c into opencraft-release/lilac.2 Feb 10, 2022
@Agrendalath Agrendalath deleted the jbcurtin/BB-5429-date-configuration-opencraft-lilac.2 branch May 21, 2022 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants