feat: default grade designations configurable from settings#541
Merged
kaustavb12 merged 1 commit intoopencraft-release/nutmeg.2from Jun 12, 2023
Merged
Conversation
(cherry picked from commit 7a7af8cdc16416ec8e3289f9482e734b58145b0e)
kaustavb12
force-pushed
the
kaustav/default_grade_designations_nutmeg
branch
from
edb22a4 to
4e93117
Compare
keithgg
approved these changes
Jun 12, 2023
keithgg
left a comment
keithgg
left a comment
There was a problem hiding this comment.
👍 LGTM @kaustavb12
- I read through the code
- I checked that the diff matches the upstream PR. Except for an errant comma, it does.
xitij2000
pushed a commit
that referenced
this pull request
Jun 27, 2023
(cherry picked from commit 7a7af8cdc16416ec8e3289f9482e734b58145b0e) (cherry picked from commit 9475431)
0x29a
pushed a commit
that referenced
this pull request
Dec 28, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(cherry picked from commit 7a7af8cdc16416ec8e3289f9482e734b58145b0e)
cherry pick for PR#32406