Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MCKIN-26505 Arabic -> Step Builder -> Score Summary -> The translations are not correct if the none of the questions are right/partially right/incorrect #317

Merged
merged 2 commits into from
Oct 21, 2020

Conversation

wasifarbisoft
Copy link
Contributor

@wasifarbisoft wasifarbisoft commented Oct 20, 2020

Translation for ZERO questions answered was missing for Arabic.

…ns are not correct if the none of the questions are right-partially right-incorrect
@wasifarbisoft
Copy link
Contributor Author

wasifarbisoft commented Oct 20, 2020

@xitij2000 Please review this PR
It's corresponding Python3 PR. #318

Copy link
Member

@viadanna viadanna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go 👍

  • I tested this
  • I read through the code.

@viadanna viadanna merged commit 0726850 into open-craft:problem-builder-v3 Oct 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants