fix: do not use the runtime.replace_urls when the runtime is not ready
#349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This happens while generating the Block Structures.
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #349 +/- ##
=======================================
Coverage 45.08% 45.08%
=======================================
Files 40 40
Lines 3309 3309
Branches 463 463
=======================================
Hits 1492 1492
Misses 1769 1769
Partials 48 48
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
|
@Agrendalath Can you please tag a release so this gets onto PyPI? |
|
@bradenmacdonald, done. Thanks for the reminder. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This happens while generating the Block Structures.
Please see the description of openedx/xblock-drag-and-drop-v2#318 for a detailed explanation of this scenario. Unlike that change, this one is backward-compatible with Maple. I didn't switch this XBlock to the
replace_urlsruntime service because it will require more changes - therefore, it makes more sense to schedule a separate task to remove all deprecated runtime attributes from here in one pass and perform detailed regression tests. This one is only a simple fix.