Fix error message display when CSV export fails [MNG-2273]#92
Merged
bradenmacdonald merged 1 commit intomasterfrom Jul 9, 2021
Merged
Fix error message display when CSV export fails [MNG-2273]#92bradenmacdonald merged 1 commit intomasterfrom
bradenmacdonald merged 1 commit intomasterfrom
Conversation
AhtishamShahid
approved these changes
Jun 30, 2021
|
👍
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the "Export to CSV" button fails to launch a task, it currently doesn't display the error message properly. Instead, an error message can only be seen in the browser console, which just says
error is undefined.This fixes the code so that the actual error message will be displayed:
See https://openedx.atlassian.net/browse/TNL-8370 and https://github.com/edx/edx-platform/pull/28019 for more information about this issue.