Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Metadata URI #13

Merged
merged 15 commits into from
May 24, 2024
Merged

Metadata URI #13

merged 15 commits into from
May 24, 2024

Conversation

daopunk
Copy link
Member

@daopunk daopunk commented May 21, 2024 •
edited
Loading

added logic to Vault721Adapter contract
closes #10

added test_getTraitMetadataURI, test_constants unit tests
closes #11

@daopunk daopunk requested review from pi0neerpat and MrDeadCe11 May 21, 2024 22:45
pi0neerpat
pi0neerpat requested changes May 22, 2024
View reviewed changes
Copy link
Member

@pi0neerpat pi0neerpat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please re-request when ready

@daopunk
Copy link
Member Author

daopunk commented May 23, 2024

Screenshot 2024-05-22 at 7 16 30 PM

@daopunk
Copy link
Member Author

daopunk commented May 23, 2024

@pi0neerpat Sol version is broken
Screenshot 2024-05-22 at 7 43 05 PM

@daopunk daopunk requested a review from pi0neerpat May 23, 2024 02:43
@daopunk daopunk merged commit 2f68653 into main May 24, 2024
2 checks passed
@daopunk daopunk deleted the metadata branch May 24, 2024 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pi0neerpat pi0neerpat pi0neerpat approved these changes

@MrDeadCe11 MrDeadCe11 Awaiting requested review from MrDeadCe11

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Additional unit testing Apply changes to getTraitMetadata
2 participants
@daopunk @pi0neerpat