Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Solidity natSpec #20

Merged
merged 4 commits into from
May 30, 2024
Merged

Solidity natSpec #20

merged 4 commits into from
May 30, 2024

Conversation

daopunk
Copy link
Member

@daopunk daopunk commented May 29, 2024 •
edited
Loading

partial solve for #17

primary function order:

  1. constructor
  2. receive function (if exists)
  3. fallback function (if exists)
  4. external
  5. public
  6. internal
  7. private

secondary considerations:

  1. view
  2. pure

https://docs.soliditylang.org/en/v0.8.26/natspec-format.html
https://docs.soliditylang.org/en/v0.8.26/style-guide.html

@daopunk daopunk requested a review from pi0neerpat May 29, 2024 19:03
@pi0neerpat
Copy link
Member

Still a wip? I don't see any new code comments

pi0neerpat
pi0neerpat requested changes May 29, 2024
View reviewed changes
Copy link
Member

@pi0neerpat pi0neerpat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Waiting on comments

@daopunk daopunk merged commit 75b0cfd into main May 30, 2024
2 checks passed
@daopunk daopunk deleted the sol-natSpec branch May 30, 2024 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pi0neerpat pi0neerpat pi0neerpat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@daopunk @pi0neerpat