Support for NeuropixelsV1e headstages #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glopesdev
changed the title
glopesdev
force-pushed
the
issue-85
branch
3 times, most recently
from
c5ccf9c to
ff58381
Compare
- The channel map is not currently configurable (uses default) - There may be an issue with this headstage because as documented in the comments around line 287 of NeurpixelsV1eSettings.cs, the second shift register write sequence always has trouble, regardless of which shift register is accessed and the contents that is written.
- Soft reset register is used betweens shift register write sequences to get through configuration without error. Requires testing. Eventual hardware revision with stronger MCLK drive may be required.
- More closely follows the patterns and types for V2 probes
glopesdev
requested changes
Jun 19, 2024
OpenEphys.Onix/OpenEphys.Onix/ConfigureNeuropixelsV1eHeadstage.cs
Outdated
Show resolved
Hide resolved
jonnew
commented
Jun 19, 2024
OpenEphys.Onix/OpenEphys.Onix/ConfigureNeuropixelsV1eHeadstage.cs
Outdated
Show resolved
Hide resolved
OpenEphys.Onix/OpenEphys.Onix/ConfigureNeuropixelsV1eHeadstage.cs
Outdated
Show resolved
Hide resolved
- Fix typos and incorrect description text - Take advantage of of automatic headstage port voltage override functionality that is now available in ConfigureFmcLinkController base class - Add more context to exception resulting from lack of communication with the probe's EEPROM. Not sure if I did this correctly (feels wrong to catch generic Exception even if im rethrowing).
|
One thing to check before review: https://github.com/neurogears/onix-refactor/blob/fdde6c3328141caf6cee2c2e098cd79cb390bf1e/OpenEphys.Onix/OpenEphys.Onix/ConfigureNeuropixelsV1e.cs#L136 This is very helpful to user and to us for support, but I'm not sure if catching a generic Exception is bad practice. I think something similar to this might be better (opposite logic but same specificity of exception type) |
glopesdev
requested changes
Jun 25, 2024
- Move exception to metadata class - Remove unused address declaration - Internalize implementation level enums - Rename values and types for clarity
glopesdev
approved these changes
Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains most functionality for HeadstageNeuropixelsV1e. It is missing shank configuration which is closely tied into GUI development on issue-106.
Fixes #85