Unify processor architecture and avoid exposing internal implementation classes #172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During reorganization of the project for packaging we noticed that there were a few bits still raising warnings on the compiler, specifically related to mismatched processor architectures. The current version of the package targets 64-bit platforms.
Additionally, we also removed internal undocumented implementation classes from the public API surface. These are all types which, while being important for the internal library architecture, are not currently required outside of the library. Keeping them internal will allow us to change their API surface until such time when we need to make them public (if ever).
Finally, the
ConfigureDS90UB9xoperator was removed since it is not really possible to work with the raw serializer stream directly from the workflow without extensive configuration in code and dedicated data nodes.