-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor ONIX core interface #21
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #3 and #4, the current ONIX package depends on design-time hardware connections to the PCIe and other ONI hosts for configuring device properties before and during workflow execution. This can be problematic as it makes it hard to inspect and modify workflows without having an active system plugged in. Having to constantly refresh connections to the host was also found to be problematic on lower-end ONI hosts such as the new USB version of the OE board implementing the ONI standard.
The redesigned interface proposed here assumes a different design stance whereby all device configuration flows from the workflow to the hardware, with no connection required for editing node properties. Initialization is now performed in an explicit chain at the top of the workflow, flowing from the new
CreateContext
node which is then passed through a series of device initialization nodes before starting acquisition.ONI device initialization can itself be grouped into "hub" nodes that represent physical assemblies of devices such as the 64-channel or NP headstages. These hubs are now represented and configured explicitly in the workflow. Runtime interactions with devices are still done through sources and sinks for the different device functionalities.
Main features