Expose headstage port status data stream #217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fixes #156 - Rename *FmcLink* to *Port* - Improve error string when SERDES lock cannot be established - Move PortName enum into ConfigurePortController.cs
bparks13
approved these changes
Aug 15, 2024
| /// </summary> | ||
| [Description("Configures an ONIX headstage-64 in the specified port.")] | ||
| public class ConfigureHeadstage64 : MultiDeviceFactory | ||
| { | ||
| PortName port; | ||
| readonly ConfigureHeadstage64LinkController LinkController = new(); | ||
| readonly ConfigureHeadstage64PortController LinkController = new(); |
There was a problem hiding this comment.
Is it worth updating the name of the variable itself to reflect the class name change?
There was a problem hiding this comment.
I considered this but PortController would conflict with the type of the same name. I was thinking about it and then gave up. If you have an idea for replacement ill take it.
- PortController was prefereable but clashed with the static class PortController, requiring its namespace prefix to be used to disinguish it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
*FmcLink*to*Port*