Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement ConfigureNeuropixelV1/2eBno055.Enable #220

Merged
merged 1 commit into from
Aug 20, 2024
Merged

Implement ConfigureNeuropixelV1/2eBno055.Enable #220

merged 1 commit into from
Aug 20, 2024

Conversation

jonnew
Copy link
Member

@jonnew jonnew commented Aug 15, 2024

  • Fixes ConfigureNeuropixelsV2eBno055.Enable has no effect #191
  • Previously ConfigureNeuropixelV1/2eBno055.Enable was not doing anything
  • Now enable state is passed through a custom DeviceInfo object to the NeuropixelV1/2eBno055Data operator. If its false, the operator returns an Observable.Empty.

@jonnew
Implement ConfigureNeuropixelV1/2eBno055.Enable
499b815 
- Fixes #191
- Previously ConfigureNeuropixelV1/2eBno055.Enable was not doing
  anything
- Now enable state is passed through a custom DeviceInfo object to
  the NeuropixelV1/2eBno055Data operator. If its false, the operator
  returns an Observable.Empty<Bno055DataFrame>.
@jonnew jonnew requested review from glopesdev and bparks13 August 15, 2024 15:46
bparks13
bparks13 approved these changes Aug 15, 2024
View reviewed changes
Copy link
Member

@bparks13 bparks13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

On a related note, I noticed that in ConfigureBno055 it does not cache the Enable property. To keep things clean I can open a separate issue for that, or we can add it in here.

@jonnew jonnew merged commit 3563597 into main Aug 20, 2024
6 checks passed
@jonnew jonnew deleted the issue-191 branch August 20, 2024 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bparks13 bparks13 bparks13 approved these changes

@glopesdev glopesdev Awaiting requested review from glopesdev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ConfigureNeuropixelsV2eBno055.Enable has no effect
2 participants
@jonnew @bparks13