-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GUI for Neuropixels V1e #231
Conversation
- Ensure reference contacts are correctly highlighted - Update adc/gain calibration file parsing - Fix anchors for controls to allow resizing more fluidly - Add icons to dialogs - Add zoom in boundary - Reduce scale bar thickness - Fix splitter panel distance
- Until we can properly validate files using a schema, we cannot parse the calibration files using the GUI as any exceptions cause the dialog to crash
We will need to bring the changes from #243 into this PR, I suppose. |
@jonnew actually we won't need to, the scaling issues occurred at the device/headstage level, not the common framework level. Meaning, I was able to fix the |
- Make labels uniform - Tool tips on NP1.0 and uniform messages - Uniform look and feel (background color, track bar)
@bparks13 I made some minor changes to make the NP GUIs more uniform. Once you confirm I have not broken anything, lets merge this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please perform a final sanity check on my latest small changes and then we can merge.
- A panel was removed, but the relevant code was left in place, leading to build errors
This PR aims to add a dialog GUI for the
NeuropixelsV1e
headstage.Controls are based on
NeuropixelsV2e
GUI, for more info on the controls see #214.One major difference between V1 and V2 is that V1 has two separate calibration files that are required (Gain and ADC). The probe will not be visible unless both files exist and are selected.
Closes #106