Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add visualizers for Quaternion and Vector3 #238

Merged
merged 2 commits into from
Aug 21, 2024
Merged

Add visualizers for Quaternion and Vector3 #238

merged 2 commits into from
Aug 21, 2024

Conversation

jonnew
Copy link
Member

@jonnew jonnew commented Aug 21, 2024

@jonnew
Add visualizers for Quaternion and Vector3
59a8bba 
- Both of these System.Numerics types are used data frames
  (Bno055DataFrame and TS4231V1PositionDataFrame)
@jonnew jonnew requested a review from bparks13 August 21, 2024 15:38
glopesdev
glopesdev reviewed Aug 21, 2024
View reviewed changes
Copy link
Collaborator

@glopesdev glopesdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the interests of avoiding clashes with the official libraries, I would change the namespace in these files.

@jonnew
Copy link
Member Author

jonnew commented Aug 21, 2024

oops, thank you.

@jonnew
Fix Vector3 and Quaternion visualizer namespace
d613e0b 
- Accidentally copied namespace from Bonsai.Vision.Design
  where I copied the template for these classes from
@jonnew jonnew merged commit 549771b into main Aug 21, 2024
6 checks passed
@jonnew jonnew deleted the issue-136 branch August 21, 2024 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glopesdev glopesdev glopesdev left review comments

@bparks13 bparks13 Awaiting requested review from bparks13

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Consider adding default visualizers for Quaternion data
2 participants
@jonnew @glopesdev