Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Bno055CalibrationFlags #240

Merged
merged 1 commit into from
Aug 22, 2024
Merged

Update Bno055CalibrationFlags #240

merged 1 commit into from
Aug 22, 2024

Conversation

jonnew
Copy link
Member

@jonnew jonnew commented Aug 21, 2024

@jonnew
Update Bno055CalibrationFlags
cb05f7c 
- The possible calibration flags were only partially defined.
@jonnew jonnew requested a review from bparks13 August 21, 2024 16:48
bparks13
bparks13 approved these changes Aug 21, 2024
View reviewed changes
Copy link
Member

@bparks13 bparks13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, confirmed that all data nodes (Bno055, NeuropixelsV1eBno055, and NeuropixelsV2eBno055) all work correctly, outputting Calibration and chaining a HasFlag node displays the correct enums added here.

@jonnew jonnew merged commit b7aae5e into main Aug 22, 2024
6 checks passed
@jonnew jonnew deleted the issue-237 branch August 22, 2024 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bparks13 bparks13 bparks13 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bno055CalibrationFlags are not actually flags
2 participants
@jonnew @bparks13