Support for headstage-nric1384-203390 #254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
jonnew
commented
Aug 26, 2024
jonnew
commented
- Fixes Add support for headstage-nric1384-203390 #70
- Not yet ready for review. We are working through some firmware issues and need to confirm full functionality before a proper review takes place.
bparks13
approved these changes
Sep 3, 2024
- I want to wait to merge until the parallel refactor of gain and adc calibration file parsing is done so I can make use of that.
- Remove some redundancy when parsing calibration files - Fix error in NeuropixelsV1eAdcCalibration that is preventing any valid file from being parsed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.