Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unique documentation to Generate() overrides #289

Merged
merged 2 commits into from
Sep 6, 2024
Merged

Add unique documentation to Generate() overrides #289

merged 2 commits into from
Sep 6, 2024

Conversation

@jonnew jonnew requested a review from cjsha September 5, 2024 18:48
Copy link
Member

@cjsha cjsha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these are nice improvements. I approved, but please go through and consider comments before merging.

OpenEphys.Onix1/BreakoutAnalogOutput.cs Show resolved Hide resolved
OpenEphys.Onix1/BreakoutAnalogOutput.cs Outdated Show resolved Hide resolved
OpenEphys.Onix1/BreakoutAnalogOutput.cs Outdated Show resolved Hide resolved
OpenEphys.Onix1/BreakoutAnalogOutput.cs Outdated Show resolved Hide resolved
OpenEphys.Onix1/BreakoutAnalogOutput.cs Outdated Show resolved Hide resolved
OpenEphys.Onix1/BreakoutAnalogOutput.cs Outdated Show resolved Hide resolved
@bparks13 bparks13 added this to the 0.3.0 milestone Sep 6, 2024
- Remove self-referential cref to DataType in XML docs
@jonnew jonnew merged commit 8ded0ba into main Sep 6, 2024
7 checks passed
@jonnew jonnew deleted the issue-203 branch September 6, 2024 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants