Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix broken HarpSyncInput reference in xml comment #293

Merged
merged 1 commit into from
Sep 6, 2024
Merged

Fix broken HarpSyncInput reference in xml comment #293

merged 1 commit into from
Sep 6, 2024

Conversation

cjsha
Copy link
Member

@cjsha cjsha commented Sep 6, 2024

  • HarpSyncInput does not exist; HarpSyncInputData does however

@cjsha
Fix broken HarpSyncInput reference in xml comment
d3ac8a8 
- HarpSyncInput does not exist; HarpSyncInput does however
@cjsha cjsha requested review from jonnew and bparks13 September 6, 2024 20:10
bparks13
bparks13 approved these changes Sep 6, 2024
View reviewed changes
Copy link
Member

@bparks13 bparks13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small correction; HarpSyncInput does exist, which is why it is a valid XML comment and is not flagged by the IDE. However, it is an internal class so it is not exposed by the website. Either way, this change fixes the link to point to the correct operator.

@bparks13 bparks13 merged commit 5cd4f83 into main Sep 6, 2024
7 checks passed
@bparks13 bparks13 deleted the fix-broken-HarpSyncInput-reference branch September 6, 2024 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bparks13 bparks13 bparks13 approved these changes

@jonnew jonnew Awaiting requested review from jonnew

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cjsha @bparks13