headstage-rhs2116 support #312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Includes squashed commits from issue-26 - Cleanup internal code - Brought Rhs2116 Dialogs up to date with common framework functionality - Fixed several errors in logic when multiple probes are utilized - Add XML comments to all public properties and methods - Added categories to Configure nodes - Removed documentation link, not necessary or maintainable - Changed the containers from splitter panels to flow layout / table layout panels to handle different scale zooms - Fixed an error introduced during refactoring that screwed up the Y-axis labels - Fixed incorrect logic for reading and writing parameters from / to electrodes - Modified the default font size to be more legible
- Fully functional sychronized rhs2116 pair with common configuration properties - GUIs work but labels might be messed up
- Subscribe -> SubscribeSafe for property behavior subjects - Device registration occurs after all Property Subscribe safe calls when returning CompositeDisposable - Naming and XML fixes
|
Addressed most of the comments, there are a couple that need further clarification |
…r waveforms - Step size is no longer selectable; users enter a target amplitude, and the smallest possible step size is chosen automatically - Step size is now only updated during `Add Pulses`; existing amplitudes are preserved if possible, or removed if they are incompatible with the new step size - Cathodic / anodic amplitudes are now processed correctly if `Biphasic Symmetric` is unchecked - Added a parsing check for the data grid view in case the user tries to manually enter a value outside of the bounds of a byte - Add icon to dialogs - Reversed Y-axis orientation for waveforms - The waveform now zooms in on the cursor, and has boundaries both zooming in and zooming out
|
Ok, we are getting down to the frivolous stuff:
|
- Scale bar automatically adjusts to show the current time / amplitude - Zoom logic updated to enable smoother transitions at the edges, not as jumpy now when reaching the edge of the boundary - Y-Axis is now channel number instead of the amplitude values
- Zero-index the waveform channels - Truncate times in the scale bar to minimize visual clutter - Increase specificity of error message when step sizes are inconsistent - Modified button names to be more clear
bparks13
approved these changes
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR combines @bparks13's GUI work and @jonnew's dual rhs2116 support. It supersedes #67
Fixes #122
Fixes #26
Fixes #320
Fixes #221
Fixes #308