Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed step size logic for Rhs2116 dialogs #342

Merged
merged 2 commits into from
Oct 22, 2024
Merged

Fixed step size logic for Rhs2116 dialogs #342

merged 2 commits into from
Oct 22, 2024

Conversation

bparks13
Copy link
Member

Update logic for choosing step sizes. Also fixed how values are read from existing stimuli.

Updated error message to be more user-friendly, focuses on the amplitude (which is user-defined) instead of the step size (which is automatically selected based on the amplitude).

Fixed alignment of Apply button.

- Also fixed how values are read from existing stimuli
@bparks13 bparks13 added this to the 0.4.0 milestone Oct 21, 2024
@bparks13 bparks13 requested a review from jonnew October 21, 2024 21:31
Copy link
Member

@jonnew jonnew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review performed during meeting and by playing with GUI afterwards

@jonnew jonnew merged commit 18dd66b into main Oct 22, 2024
7 checks passed
@jonnew jonnew deleted the rhs-gui-updates branch October 22, 2024 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants