-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update readme and URLs #350
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Bump version number
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I addressed all of the comments by @jonnew, and I updated the version number so that the actions would pass.
However, I noticed that in the build-and-run.png
file, there is only the numbers for 3 and 4. Did we change the image?
- Provide context for screenshots by adding labels that correspond to numbered bullet points in the written content
I haven't changed I don't think we had it like jon does in the "Enable Debugging" section that we'd created. In the latest commit, I try to amend that. Thanks for addressing his comments @bparks13 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks good to me now, but there are a few commits going back and forth; before merging to main, I would recommend someone go through and squash commits together to clean up the history
- Minor changes
@cjsha please squash and merge |
The important thing from this PR is that we need to update the URLs (after the repo name changed) so that the nodes that are published on nuget are linked to the actual docs site. Currently the "F1" Help functionality doesn't work for our nodes. I think this should fix that.
I also added some instructions to the README to document how to setup breakpoints in Visual Studio.