Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify PortStatusFrame #362

Merged
merged 3 commits into from
Nov 12, 2024
Merged

Simplify PortStatusFrame #362

merged 3 commits into from
Nov 12, 2024

Conversation

jonnew
Copy link
Member

@jonnew jonnew commented Oct 31, 2024

  • Instead of making SerdesPass and SerdesLock bools next to the code word, the a codeword valid flag required to indicate if the codeword should be none, jusst make the PortStatusCode flag enum 16-bits long and contain status code, lock, and pass status together
  • Needs to be tested with hardware
  • Code valid flag is currently not interpreted by PortStatusCode since its not relevant for this interpretation of the low level frame data, but I need to confirm that this is not going to do something strange to the StatusCode or result in exception
  • Fixes Include Lock and Pass PortStatusCode enum #351

@jonnew
Simplify PortStatusFrame
2d19d16 
- Instead of making SerdesPass and SerdesLock bools next to the code
  word, the a codeword valid flag required to indicate if the codeword
  should be none, jusst make the PortStatusCode flag enum 16-bits long
  and contain status code, lock, and pass status together
- Needs to be tested with hardware
- Code valid flag is currently not interpreted by PortStatusCode since
  its not relevant for this interpretation of the low level frame data,
  but I need to confirm that this is not going to do something strange
  to the StatusCode or result in exception
@jonnew jonnew added this to the 0.5.0 milestone Oct 31, 2024
@jonnew jonnew requested review from aacuevas and bparks13 November 1, 2024 17:53
aacuevas
aacuevas reviewed Nov 8, 2024
View reviewed changes
Copy link
Collaborator

@aacuevas aacuevas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The port status device defines a code with the 0x1000 flag, for crc error on init. While I do not believe this can actually reach the output, should it not be safer to add it to the enum?

@jonnew jonnew requested review from bparks13 and aacuevas November 8, 2024 16:19
@jonnew jonnew merged commit 427c752 into main Nov 12, 2024
7 checks passed
@jonnew jonnew deleted the issue-351 branch November 12, 2024 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aacuevas aacuevas aacuevas approved these changes

@bparks13 bparks13 Awaiting requested review from bparks13

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.5.0
Development

Successfully merging this pull request may close these issues.

Include Lock and Pass PortStatusCode enum
3 participants
@jonnew @aacuevas @bparks13