Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for NeuropixelsV2 public and beta headstages #45

Merged
merged 9 commits into from
Feb 13, 2024
Merged

Conversation

glopesdev
Copy link
Collaborator

@glopesdev glopesdev commented Jan 25, 2024

Leveraging the passthrough serializer interface, this PR bootstraps the required infrastructure to configure and stream data from NeuropixelsV2 devices. The current implementation has been tested on a V2 beta headstage but will require validation and testing with other probes and public devices.

The device configuration call has also been moved inside the ContextTask class to ensure configuration is disposed in the correct order in both exceptional termination and cancellation.

Fixes #37
Fixes #48

@glopesdev glopesdev added the feature New planned feature label Jan 25, 2024
@glopesdev glopesdev added this to the 0.1.0 milestone Jan 25, 2024
@glopesdev glopesdev requested a review from jonnew January 25, 2024 21:49
@glopesdev glopesdev changed the title Add support for NeuropixelsV2 public and beta headstages Support for NeuropixelsV2 public and beta headstages Jan 25, 2024
Copy link
Member

@jonnew jonnew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from these comments see this:

#47
#48

OpenEphys.Onix/OpenEphys.Onix/NeuropixelsV2BetaData.cs Outdated Show resolved Hide resolved
@glopesdev glopesdev requested a review from jonnew February 7, 2024 11:47
@glopesdev
Copy link
Collaborator Author

@jonnew One thing that maybe we didn't finalize yet is how to deal with the gain conversions, and also the logic for loading the corrections from file, I will try to make a prototype of this and incorporate in this branch.

@glopesdev
Copy link
Collaborator Author

@jonnew Actually, I think it will be easier to organize the development if we merge at this point and develop the correction logic separately.

@glopesdev glopesdev merged commit e52f7d6 into main Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New planned feature
Projects
None yet
2 participants