Update FmcLinkController port voltage algorithm #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Expose more parameters of its operation - Final link check after setting offset voltage - From testing it was found that headstage-64 needs a very large amount of time to reach an acceptable votlage level to be considered off (nearly 10 seconds) - A new virtual SetPortVoltage method was introduced in the base link controller to allow headstages to change the procedure depending on its needs. In the case of headstage-64, a two-step procedure with a long wait time after turning port voltage off, and a very large offset voltage applied after lock.
glopesdev
added
feature
|
As I said on discord, this looks like a good solution to me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #64