Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor link controller as abstract base class #68

Merged
merged 1 commit into from
Apr 2, 2024
Merged

Conversation

glopesdev
Copy link
Collaborator

@glopesdev glopesdev commented Apr 2, 2024

This PR refactors the FMC link controller as an abstract base class to allow for maximum flexibility and isolation of headstage port voltage scanning implementations. Hub link controllers will now be required to provide their own implementations by overriding ConfigurePortVoltage. A helper function for checking the link state is provided in CheckLinkState.

Two reference implementations for HS64 and NeuropixelsV2e probes are provided.

Fixes #64

@glopesdev glopesdev added feature New planned feature proposal Request for a new feature labels Apr 2, 2024
@glopesdev glopesdev added this to the 0.1.0 milestone Apr 2, 2024
@glopesdev glopesdev requested review from jonnew and aacuevas April 2, 2024 16:25
@glopesdev glopesdev merged commit 99b42ae into main Apr 2, 2024
@glopesdev glopesdev deleted the issue-64 branch April 2, 2024 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New planned feature proposal Request for a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Port voltage tuning algorithm limitations
1 participant