Redirect initialization and dispose errors #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current device configuration uses deferred execution to allow functional composition of the initialization pipeline, which is then actually executed at
StartAcquisition. This makes propagation of errors unintuitive since any exceptions are routed via theStartAcquisitionnode, no matter which step in the configuration chain they actually originated from.This PR rewrites observable configuration operators so that on subscription they store the original observer in the configuration closure, and make sure any exceptions are routed there. This allows highlighting the correct node for any exceptions in the chain.
Fixes #69