Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Make provider interface "stateless", SDK maintains provider state #250

Closed
9 tasks
toddbaert opened this issue Mar 15, 2024 · 1 comment · Fixed by #276
Closed
9 tasks

[FEATURE] Make provider interface "stateless", SDK maintains provider state #250

toddbaert opened this issue Mar 15, 2024 · 1 comment · Fixed by #276
Assignees
Labels
contribfest A good issue for Contribfest KubeCon EU '24 enhancement New feature or request v0.8.0

Comments

@toddbaert
Copy link
Member

Requirements

Stateless providers

Providers no longer maintain their own state: the state for each provider is maintained in the SDK automatically, and updated according to the success/failures of lifecycle methods (init/shutdown) or events emitted from providers spontaneously.

Tasks

@toddbaert toddbaert added enhancement New feature or request contribfest A good issue for Contribfest KubeCon EU '24 v0.8.0 labels Mar 15, 2024
@toddbaert toddbaert added this to the Spec 0.8 Compliance milestone Mar 15, 2024
@toddbaert toddbaert self-assigned this May 31, 2024
@toddbaert
Copy link
Member Author

I've started on this.

arttonoyan pushed a commit to arttonoyan/dotnet-sdk that referenced this issue Oct 16, 2024
This PR implements a few things from spec 0.8.0:

- implements internal provider status (already implemented in JS)
- the provider no longer updates its status to READY/ERROR, etc after
init (the SDK does this automatically)
  - the provider's state is updated according to the last event it fired
- adds `PROVIDER_FATAL` error and code
- adds "short circuit" feature when evaluations are skipped if provider
is `NOT_READY` or `FATAL`
- removes some deprecations that were making the work harder since we
already have pending breaking changes.

Fixes: open-feature#250

---------

Signed-off-by: Todd Baert <todd.baert@dynatrace.com>
Co-authored-by: André Silva <2493377+askpt@users.noreply.github.com>
Co-authored-by: Ryan Lamb <4955475+kinyoklion@users.noreply.github.com>
Signed-off-by: Artyom Tonoyan <artonoyan@servicetitan.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribfest A good issue for Contribfest KubeCon EU '24 enhancement New feature or request v0.8.0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant