Skip to content

Conversation

@kylejuliandev
Copy link
Contributor

This PR

  • Adds simple a AspNetCore web application with a /welcome minimal API that will show one of two messages based the configuration of the InMemory feature provider.

Related Issues

Notes

While the README for OpenFeature dotnet is pretty comprehensive, I think it can be quite intimidating to developers who are unfamilar with feature flagging and OpenFeature. Providing a basic application that can be cloned locally and run with minimal setup would improve the onboarding and upskill experience.

Additionally, as a contributor I find myself frequently creating simple applications to test out changes to OpenFeature. This would save the effort of stashing local changes and make it easier to more quickly test or prototype changes.

The example could be extended with endpoints that explore the other types of feature flags and how you might utilise them within an application.

Follow-up Tasks

Update the README with a reference to the sample application to help guide developers.

How to test

Signed-off-by: Kyle Julian <38759683+kylejuliandev@users.noreply.github.com>
Signed-off-by: Kyle Julian <38759683+kylejuliandev@users.noreply.github.com>
@kylejuliandev kylejuliandev requested a review from a team as a code owner May 19, 2025 20:20
@codecov
Copy link

codecov bot commented May 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.08%. Comparing base (6c44db9) to head (60e7c96).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #477   +/-   ##
=======================================
  Coverage   87.08%   87.08%           
=======================================
  Files          45       45           
  Lines        1757     1757           
  Branches      184      184           
=======================================
  Hits         1530     1530           
  Misses        187      187           
  Partials       40       40           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@beeme1mr beeme1mr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool idea! I'm in favor of this approach. Nice job 🥳

Copy link
Member

@askpt askpt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Two minor comments! Great effort 👍

Signed-off-by: Kyle Julian <38759683+kylejuliandev@users.noreply.github.com>
Signed-off-by: Kyle Julian <38759683+kylejuliandev@users.noreply.github.com>
@askpt askpt added this pull request to the merge queue May 21, 2025
Merged via the queue into open-feature:main with commit 9742a0d May 21, 2025
17 checks passed
askpt pushed a commit that referenced this pull request May 23, 2025
<!-- Please use this template for your pull request. -->
<!-- Please use the sections that you need and delete other sections -->

## This PR
<!-- add the description of the PR here -->

- Adds simple a AspNetCore web application with a `/welcome` minimal API
that will show one of two messages based the configuration of the
`InMemory` feature provider.

### Related Issues
<!-- add here the GitHub issue that this PR resolves if applicable -->

### Notes
<!-- any additional notes for this PR -->

While the
[README](https://github.com/open-feature/dotnet-sdk/blob/6c44db9237748735a22a162a88f61b2de7f3e9bd/README.md)
for OpenFeature dotnet is pretty comprehensive, I think it can be quite
intimidating to developers who are unfamilar with feature flagging and
OpenFeature. Providing a basic application that can be cloned locally
and run with minimal setup would improve the onboarding and upskill
experience.

Additionally, as a contributor I find myself frequently creating simple
applications to test out changes to OpenFeature. This would save the
effort of stashing local changes and make it easier to more quickly test
or prototype changes.

The example could be extended with endpoints that explore the other
types of feature flags and how you might utilise them within an
application.

### Follow-up Tasks
<!-- anything that is related to this PR but not done here should be
noted under this section -->
<!-- if there is a need for a new issue, please link it here -->

Update the
[README](https://github.com/open-feature/dotnet-sdk/blob/6c44db9237748735a22a162a88f61b2de7f3e9bd/README.md)
with a reference to the sample application to help guide developers.

### How to test
<!-- if applicable, add testing instructions under this section -->

---------

Signed-off-by: Kyle Julian <38759683+kylejuliandev@users.noreply.github.com>
Signed-off-by: André Silva <2493377+askpt@users.noreply.github.com>
github-merge-queue bot pushed a commit that referenced this pull request May 23, 2025
🤖 I have created a release *beep* *boop*
---


##
[2.6.0](v2.5.0...v2.6.0)
(2025-05-23)


### ✨ New Features

* add AddHandler extension method to Dependency Injection package
([#462](#462))
([ff414b8](ff414b8))
* Add Extension Method for adding global Hook via DependencyInjection
([#459](#459))
([9b04485](9b04485))
* Add OTEL compatible telemetry object builder
([#397](#397))
([6c44db9](6c44db9))


### 🧹 Chore

* Cleanup .props file
([#476](#476))
([6d7a535](6d7a535))
* **deps:** update actions/attest-build-provenance action to v2.3.0
([#464](#464))
([0a5ab0c](0a5ab0c))
* **deps:** update codecov/codecov-action action to v5.4.3
([#475](#475))
([fbcf3a4](fbcf3a4))
* **deps:** update github/codeql-action digest to 60168ef
([#463](#463))
([ea76351](ea76351))
* **deps:** update github/codeql-action digest to ff0a06e
([#473](#473))
([af1b20f](af1b20f))
* **deps:** update spec digest to edf0deb
([#474](#474))
([fc3bdfe](fc3bdfe))


### 📚 Documentation

* Add AspNetCore sample app
([#477](#477))
([9742a0d](9742a0d))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Signed-off-by: OpenFeature Bot <109696520+openfeaturebot@users.noreply.github.com>
Signed-off-by: André Silva <2493377+askpt@users.noreply.github.com>
Co-authored-by: André Silva <2493377+askpt@users.noreply.github.com>
@kylejuliandev kylejuliandev deleted the feature/add-aspnetcore-sample-app branch May 26, 2025 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants