Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Buf schema registry readme #34

Merged
merged 6 commits into from
Oct 21, 2022
Merged

docs: Buf schema registry readme #34

merged 6 commits into from
Oct 21, 2022

Conversation

james-milligan
Copy link
Collaborator

This PR

  • adds the buf schema registry readme

Related Issues

#28

james-milligan and others added 4 commits September 28, 2022 11:40
Signed-off-by: James-Milligan <james@omnant.co.uk>
Signed-off-by: jamesmilligan <james@omnant.co.uk>

The core definitions are in the `schema.v1` package, and contains package name options for the following languages, as a result these can be excluded from build instructions:

- Go: schema/service/v1
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

while a table would be more suitable here, its formatting is lost in the schema registry

Signed-off-by: jamesmilligan <james@omnant.co.uk>
protobuf/buf.md Outdated Show resolved Hide resolved

The core definitions are in the `schema.v1` package, and contains package name options for the following languages, as such these options may be excluded from build instructions:

- Go: schema/service/v1
Copy link
Member

@toddbaert toddbaert Oct 20, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think about taking this chance to update the go package name?

I think I'd like to see something more like the other examples. This is a nitpick though, it won't block the merge from my end.

cc @skyerus

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have another issue open for this here. I tihnk we should hold off on making this change until after kubecon, as it will change the import paths for flagd and the go provider.

Co-authored-by: Todd Baert <toddbaert@gmail.com>
Signed-off-by: James Milligan <75740990+james-milligan@users.noreply.github.com>
@james-milligan james-milligan merged commit de7cb5b into open-feature:main Oct 21, 2022
@james-milligan james-milligan deleted the schema-readme branch October 21, 2022 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants