feat: removed state as required property. Allowed variants of boolean flag to be null

[skyerus]

This PR

• removes state as required property (implementor should default to ENABLED)
• relaxed schema to allow variants of boolean flag to be null (implementor should set the variants to given default if not set)

Related Issues

Fixes #80

Notes

Follow-up Tasks

How to test

[toddbaert]

This looks right to me, but I think this was mostly @beeme1mr 's idea, so I'd like his sign off as well.

[beeme1mr]

I didn't get a chance to properly review this today. I'll look into it tomorrow.

[beeme1mr]

I tested it out today. It works but the UX isn't great at the moment. For example, adding a variant property will autocomplete the boolean variant in VS Code. It would also be nice if the default variant could be an enum contain true and false when the variant property was omitted or matched { "true": true, "false", false }.

I would love to figure out a way to autocomplete the default variant based on the variant keys but I don't think that's possible with a JSON schema.

The goal should be to make the most common use case as simple and safe as possible.

[skyerus]

For example, adding a variant property will autocomplete the boolean variant in VS Code.

This is because the boolean type is the only one with default variants. We can omit the default from the json schema and infer it in flagd if we'd rather the autocomplete created an empty object.

It would also be nice if the default variant could be an enum contain true and false when the variant property was omitted or matched { "true": true, "false", false }.
I would love to figure out a way to autocomplete the default variant based on the variant keys but I don't think that's possible with a JSON schema.

I've hunted around but not been able to find any indication that this is possible within the schema (e.g. stack overflow answer declaring it's not possible).

[toddbaert]

I tested it out today. It works but the UX isn't great at the moment. For example, adding a variant property will autocomplete the boolean variant in VS Code

I think the autocomplete experience in a particular tool isn't a good basis for deciding how we build our schema. The changes here seem to match the issue exactly.

[Kavindu-Dodan]

@beeme1mr This PR has gone stale. We should follow-up and either close or go ahead with this