review changes

Signed-off-by: Kavindu Dodanduwa <kavindudodanduwa@gmail.com>
open-feature · Mar 2, 2023 · 4f551fc · 4f551fc
1 parent 4f01565
commit 4f551fc
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 3 deletions.
diff --git a/pkg/sync/kubernetes/kubernetes_sync.go b/pkg/sync/kubernetes/kubernetes_sync.go
@@ -5,7 +5,7 @@ import (
 	"fmt"
 	"os"
 	"strings"
-	parallel "sync"
+	msync "sync"
 	"time"
 
 	"github.com/open-feature/flagd/pkg/logger"
@@ -104,7 +104,7 @@ func (k *Sync) Sync(ctx context.Context, dataSync chan<- sync.DataSync) error {
 
 	notifies := make(chan INotify)
 
-	var wg parallel.WaitGroup
+	var wg msync.WaitGroup
 
 	// Start K8s resource notifier
 	wg.Add(1)

diff --git a/pkg/sync/kubernetes/kubernetes_sync_test.go b/pkg/sync/kubernetes/kubernetes_sync_test.go
@@ -287,7 +287,7 @@ func Test_updateFuncHandler(t *testing.T) {
 			wantEvent: false,
 		},
 		{
-			name: "Simple error - API version mismatch",
+			name: "Simple error - API version mismatch new object",
 			args: args{
 				oldObj: toUnstructured(t, validFFCfgOld),
 				newObj: toUnstructured(t, v1alpha1.FeatureFlagConfiguration{
@@ -304,6 +304,24 @@ func Test_updateFuncHandler(t *testing.T) {
 			wantErr:   true,
 			wantEvent: false,
 		},
+		{
+			name: "Simple error - API version mismatch old object",
+			args: args{
+				oldObj: toUnstructured(t, v1alpha1.FeatureFlagConfiguration{
+					TypeMeta: v1.TypeMeta{
+						Kind:       "FeatureFlagConfiguration",
+						APIVersion: "someAPIVersion",
+					},
+				}),
+				newObj: toUnstructured(t, validFFCfgNew),
+				object: client.ObjectKey{
+					Namespace: cfgNs,
+					Name:      cfgName,
+				},
+			},
+			wantErr:   true,
+			wantEvent: false,
+		},
 	}
 	for _, tt := range tests {
 		t.Run(tt.name, func(t *testing.T) {