Skip to content

Commit

Permalink
chore: pin golangci-lint (#849)
Browse files Browse the repository at this point in the history
golangci requires go 1.20 now 😬 . 

We can upgrade to 1.20, but for now the change in this tool is causing
lint failures since we use `@latest` when we install it.

Signed-off-by: Todd Baert <todd.baert@dynatrace.com>
  • Loading branch information
toddbaert authored Aug 21, 2023
1 parent b7aacc0 commit f034867
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
2 changes: 1 addition & 1 deletion .pre-commit-config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,6 @@ repos:
- id: gofumpt

- repo: https://github.com/golangci/golangci-lint
rev: v1.46.2
rev: v1.50.1
hooks:
- id: golangci-lint
3 changes: 2 additions & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,8 @@ uninstall:
rm /etc/systemd/system/flagd.service
rm -f $(DESTDIR)$(PREFIX)/bin/flagd
lint:
go install -v github.com/golangci/golangci-lint/cmd/golangci-lint@latest
# pinned to @v1.53.3 until we migrate to go 1.20 (newer versions use incompatible transitive deps)
go install -v github.com/golangci/golangci-lint/cmd/golangci-lint@v1.53.3
$(foreach module, $(ALL_GO_MOD_DIRS), ${GOPATH}/bin/golangci-lint run --deadline=5m --timeout=5m $(module)/... || exit;)
install-mockgen:
go install github.com/golang/mock/mockgen@v1.6.0
Expand Down

0 comments on commit f034867

Please sign in to comment.