-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE] Change fractional
custom op from percentage-based to relative weighting.
#1282
Comments
fractional
custom op from _percentage-based_ to _relative weighting_.fractional
custom op from percentage-based to relative weighting.
+1 I think this is a good new (non-breaking) feature |
Regarding default weights, I think it'd be cleanest to allow specifying strings directly in place of arrays. Though this does become incompatible with the shorthand syntax which relies on string/arr type checking. Overall I like having the relative weighting syntax available even without the optionality of traffic weights |
We did this with Keptn and it was never understood by users. So I'm not in favour as it seems to add complexity where there doesn't need to be any. What would be nice (and perhaps this achieves this) is the ability to quickly say: 25% to red and the rest (implicitly) 75% to the default:
|
@agardnerIT How would you support 3-way experiments with 33.3% traffic share, or any non-integer traffic share then? Should we allow floats or strings in addition to integer? |
I think we should likely stick to integers only. What would be the use case for floats or strings? I also don't think this complicates the configuration. In my opinion, it would make the configuration simpler and more flexible. It is also non-breaking, so the old way would continue to work. |
@toddbaert If still available, I would like to work on this one :) |
Requirements
Currently, the fractional operator is percentage-based; meaning you must specify the relative distribution of the variants in terms of a percentage. I believe we should change this instead to be a relative weight, meaning that the integers do not need to sum to 100. For example, this fractional:
Would remain valid, but could also be expressed as:
We could even make the number in the bucket optional, so that an even split would be assumed if none was provided (we could simply default to 1).
Benefits:
1/1/1
vs33/33/34
)Challenges:
If there's a general consensus to this, I will create some child issues in the relevant repositories and use this issue as the parent "tracking" issue.
The text was updated successfully, but these errors were encountered: