feat: Change fractional custom op from percentage-based to relative weighting. #946 #954
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eighting. open-feature#946 Signed-off-by: Simon Schrottner <simon.schrottner@dynatrace.com>
aepfli
force-pushed
the
issue/946_fractional_relative_weighting
branch
from
5522613 to
2d086ce
Compare
|
it seems like i updated the submodules by accident |
aepfli
force-pushed
the
issue/946_fractional_relative_weighting
branch
from
015258f to
91b0bba
Compare
Signed-off-by: Simon Schrottner <simon.schrottner@dynatrace.com>
aepfli
force-pushed
the
issue/946_fractional_relative_weighting
branch
from
91b0bba to
5fa3d71
Compare
|
relates also to: open-feature/flagd#1282 - for tracking purpose in the main ticket |
toddbaert
reviewed
Jun 27, 2024
toddbaert
approved these changes
Jun 27, 2024
|
Wow thanks so much @aepfli ! Only left 2 minor comments. |
toddbaert
reviewed
Jun 27, 2024
|
@aepfli testbed v0.5.5 is available now. If you update our test containers and the submodule to that version, the new tests e2e should work (I tested them locally on this branch). |
Signed-off-by: Simon Schrottner <simon.schrottner@dynatrace.com>
aepfli
force-pushed
the
issue/946_fractional_relative_weighting
branch
from
3203f25 to
ff1e2da
Compare
toddbaert
approved these changes
Jul 2, 2024
This was referenced Jul 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Fixes #946