Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add component tag #1050

Merged

Conversation

Kavindu-Dodan
Copy link
Contributor

This PR

Attempt to fix release please for mono repo releases

Signed-off-by: Kavindu Dodanduwa <kavindudodanduwa@gmail.com>
@Kavindu-Dodan Kavindu-Dodan requested a review from a team as a code owner December 4, 2023 17:20
Copy link

netlify bot commented Dec 4, 2023

Deploy Preview for polite-licorice-3db33c canceled.

Name Link
🔨 Latest commit 5a20e7d
🔍 Latest deploy log https://app.netlify.com/sites/polite-licorice-3db33c/deploys/656e0a6d098a4a000889b5f1

Copy link

codecov bot commented Dec 4, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (393ff31) 71.96% compared to head (5a20e7d) 71.96%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1050   +/-   ##
=======================================
  Coverage   71.96%   71.96%           
=======================================
  Files          28       28           
  Lines        2864     2864           
=======================================
  Hits         2061     2061           
  Misses        699      699           
  Partials      104      104           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@beeme1mr
Copy link
Member

beeme1mr commented Dec 4, 2023

Hey @Kavindu-Dodan, could you elaborate more on the problem you're trying to solve and why this may help?

@Kavindu-Dodan
Copy link
Contributor Author

Kavindu-Dodan commented Dec 4, 2023

Hey @Kavindu-Dodan, could you elaborate more on the problem you're trying to solve and why this may help?

RP opened updated this PR to release full package with version 1.0.0 - #1038. And seems this is due to a breaking change introduced to release please in v4 (repo upgraded - #1047) and release PR upgrade commit (9c9a2da) just after the RP version bump.

I assume this is because v4 ignores monorepo-tags and expect the include-component-in-tag

@Kavindu-Dodan Kavindu-Dodan merged commit 361a301 into open-feature:main Dec 4, 2023
14 checks passed
@github-actions github-actions bot mentioned this pull request Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants