-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: auto update config docs #305
Merged
skyerus
merged 4 commits into
open-feature:main
from
skyerus:issue-243_auto-generate-config-docs
Jan 24, 2023
Merged
chore: auto update config docs #305
skyerus
merged 4 commits into
open-feature:main
from
skyerus:issue-243_auto-generate-config-docs
Jan 24, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skyerus
requested review from
AlexsJones,
james-milligan and
toddbaert
as code owners
January 23, 2023 14:36
beeme1mr
reviewed
Jan 23, 2023
beeme1mr
reviewed
Jan 23, 2023
beeme1mr
approved these changes
Jan 23, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very cool!
Signed-off-by: Skye Gill <gill.skye95@gmail.com>
Signed-off-by: Skye Gill <gill.skye95@gmail.com>
Signed-off-by: Skye Gill <gill.skye95@gmail.com>
skyerus
force-pushed
the
issue-243_auto-generate-config-docs
branch
from
January 23, 2023 15:38
6158085
to
4af7f9e
Compare
Kavindu-Dodan
approved these changes
Jan 23, 2023
toddbaert
approved these changes
Jan 23, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love it.
Checking it in the CI (therefor forcing it to be committed) is the best approach, I think.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
make generate-docs
which auto generates cmd config documentationmake generate-docs
)Related Issues
Fixes #243
Notes
Follow-up Tasks
How to test