Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: deprecation warning fix #317

Merged
merged 2 commits into from
Jan 25, 2023
Merged

fix: deprecation warning fix #317

merged 2 commits into from
Jan 25, 2023

Conversation

james-milligan
Copy link
Contributor

Signed-off-by: jamesmilligan james@omnant.co.uk

This PR

  • fixes incorrect default on deprecation warning, preventing warning log when the flag is not used

Related Issues

Notes

Follow-up Tasks

How to test

Signed-off-by: jamesmilligan <james@omnant.co.uk>
@beeme1mr beeme1mr self-requested a review January 25, 2023 16:15
Copy link
Member

@beeme1mr beeme1mr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@toddbaert toddbaert merged commit a2630db into open-feature:main Jan 25, 2023
beeme1mr pushed a commit that referenced this pull request Jan 26, 2023
🤖 I have created a release *beep* *boop*
---


##
[0.3.2](v0.3.1...v0.3.2)
(2023-01-26)


### Bug Fixes

* deprecation warning fix
([#317](#317))
([a2630db](a2630db))
* **deps:** update kubernetes packages to v0.26.1
([#267](#267))
([26825f2](26825f2))
* **deps:** update module github.com/diegoholiveira/jsonlogic/v3 to
v3.2.7 ([#283](#283))
([2ab5a00](2ab5a00))
* **deps:** update module github.com/open-feature/open-feature-operator
to v0.2.24 ([#290](#290))
([38d3eba](38d3eba))
* **deps:** update module github.com/open-feature/open-feature-operator
to v0.2.25 ([#324](#324))
([ed1d3aa](ed1d3aa))
* **deps:** update module github.com/spf13/viper to v1.15.0
([#296](#296))
([d43220b](d43220b))
* **deps:** update module google.golang.org/grpc to v1.52.1
([#314](#314))
([ad25388](ad25388))
* **deps:** update module google.golang.org/grpc to v1.52.3
([#325](#325))
([8013ea5](8013ea5))
* Update flagd systemd config to use URI
([#315](#315))
([93a04b4](93a04b4))
* update outdated doc link in deprecation warning
([#316](#316))
([19695d2](19695d2))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants