-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(flagd): update profile.Dockerfile with buildkit caching #723
refactor(flagd): update profile.Dockerfile with buildkit caching #723
Conversation
Signed-off-by: Lam Tran <lam.tran@spenmo.com>
5df353e
to
5aaa499
Compare
Codecov Report
@@ Coverage Diff @@
## main #723 +/- ##
=======================================
Coverage 73.68% 73.68%
=======================================
Files 26 26
Lines 2603 2603
=======================================
Hits 1918 1918
Misses 612 612
Partials 73 73 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks!
Would you be interested in optimizing the build.Dockerfile
as well?
No idea why Codecov thinks the coverage when down but it can safely be ignored. |
Yes, I will give 2 separate PRs for flagd/build.Dockerfile and flagd-proxy/build.Dockerfile |
🤖 I have created a release *beep* *boop* --- <details><summary>flagd: 0.6.0</summary> ## [0.6.0](flagd/v0.5.4...flagd/v0.6.0) (2023-07-13) ### ⚠ BREAKING CHANGES * rename metrics and service ([#730](#730)) ### 🐛 Bug Fixes * **deps:** update module github.com/open-feature/flagd/core to v0.5.4 ([#693](#693)) ([33705a6](33705a6)) * **deps:** update module github.com/open-feature/go-sdk-contrib/providers/flagd to v0.1.13 ([#697](#697)) ([435448f](435448f)) * **deps:** update module github.com/spf13/viper to v1.16.0 ([#679](#679)) ([798a975](798a975)) ### 🔄 Refactoring * **flagd:** update build.Dockerfile with buildkit caching ([#724](#724)) ([3e9cc1a](3e9cc1a)) * **flagd:** update profile.Dockerfile with buildkit caching ([#723](#723)) ([3f263c6](3f263c6)) * remove protobuf dependency from eval package ([#701](#701)) ([34ffafd](34ffafd)) </details> <details><summary>flagd-proxy: 0.2.5</summary> ## [0.2.5](flagd-proxy/v0.2.4...flagd-proxy/v0.2.5) (2023-07-13) ### 🐛 Bug Fixes * **deps:** update module github.com/open-feature/flagd/core to v0.5.4 ([#693](#693)) ([33705a6](33705a6)) * **deps:** update module github.com/spf13/viper to v1.16.0 ([#679](#679)) ([798a975](798a975)) ### 🔄 Refactoring * **flagd-proxy:** update build.Dockerfile with buildkit caching ([#725](#725)) ([06f3d2e](06f3d2e)) * remove protobuf dependency from eval package ([#701](#701)) ([34ffafd](34ffafd)) </details> <details><summary>core: 0.6.0</summary> ## [0.6.0](core/v0.5.4...core/v0.6.0) (2023-07-13) ### ⚠ BREAKING CHANGES * rename metrics and service ([#730](#730)) ### 🔄 Refactoring * remove protobuf dependency from eval package ([#701](#701)) ([34ffafd](34ffafd)) ### 🐛 Bug Fixes * **deps:** update kubernetes packages to v0.27.3 ([#708](#708)) ([5bf3a69](5bf3a69)) * **deps:** update module github.com/bufbuild/connect-go to v1.9.0 ([#722](#722)) ([75223e2](75223e2)) * **deps:** update module github.com/bufbuild/connect-opentelemetry-go to v0.4.0 ([#739](#739)) ([713e2a9](713e2a9)) * **deps:** update module github.com/prometheus/client_golang to v1.16.0 ([#709](#709)) ([b8bedd2](b8bedd2)) * **deps:** update module golang.org/x/crypto to v0.10.0 ([#647](#647)) ([7f1d7e6](7f1d7e6)) * **deps:** update module golang.org/x/mod to v0.11.0 ([#705](#705)) ([42813be](42813be)) * **deps:** update module golang.org/x/mod to v0.12.0 ([#729](#729)) ([7b109c7](7b109c7)) * **deps:** update module golang.org/x/net to v0.11.0 ([#706](#706)) ([27d893f](27d893f)) * **deps:** update module golang.org/x/sync to v0.3.0 ([#707](#707)) ([7852efb](7852efb)) * **deps:** update module google.golang.org/grpc to v1.56.1 ([#710](#710)) ([8f16573](8f16573)) * **deps:** update module google.golang.org/grpc to v1.56.2 ([#738](#738)) ([521cc30](521cc30)) * **deps:** update module google.golang.org/protobuf to v1.31.0 ([#720](#720)) ([247239e](247239e)) * **deps:** update opentelemetry-go monorepo ([#648](#648)) ([c12dad8](c12dad8)) ### ✨ New Features * **flagD:** support zero downtime during upgrades ([#731](#731)) ([7df8d39](7df8d39)) * rename metrics and service ([#730](#730)) ([09c0198](09c0198)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Signed-off-by: Kavindu Dodanduwa <kavindudodanduwa@gmail.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Kavindu Dodanduwa <kavindudodanduwa@gmail.com>
This PR
updates
flagd/profile.Dockerfile
with changes:Related Issues
Notes
docker init
(reference: https://docs.docker.com/engine/reference/commandline/init/#example-of-selecting-go)Follow-up Tasks
How to test