-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(go-feature-flag)!: GO Feature Flag provider rebuild #547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Thomas Poignant <thomas.poignant@gofeatureflag.org>
Signed-off-by: Thomas Poignant <thomas.poignant@gofeatureflag.org>
Signed-off-by: Thomas Poignant <thomas.poignant@gofeatureflag.org>
Signed-off-by: Thomas Poignant <thomas.poignant@gofeatureflag.org>
Signed-off-by: Thomas Poignant <thomas.poignant@gofeatureflag.org>
Signed-off-by: Thomas Poignant <thomas.poignant@gofeatureflag.org>
Signed-off-by: Thomas Poignant <thomas.poignant@gofeatureflag.org>
Signed-off-by: Thomas Poignant <thomas.poignant@gofeatureflag.org>
Signed-off-by: Thomas Poignant <thomas.poignant@gofeatureflag.org>
Signed-off-by: Thomas Poignant <thomas.poignant@gofeatureflag.org>
beeme1mr
reviewed
Jul 30, 2024
Signed-off-by: Thomas Poignant <thomas.poignant@gofeatureflag.org>
Signed-off-by: Thomas Poignant <thomas.poignant@gofeatureflag.org>
thomaspoignant
force-pushed
the
goff-provider-v1
branch
from
July 30, 2024 17:51
db8f685
to
e03d286
Compare
Still need to read this code few times more to get my head around but looks healthy |
Will review. |
toddbaert
reviewed
Aug 14, 2024
toddbaert
reviewed
Aug 14, 2024
toddbaert
reviewed
Aug 14, 2024
toddbaert
approved these changes
Aug 14, 2024
Signed-off-by: Thomas Poignant <thomas.poignant@gofeatureflag.org>
This was referenced Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
In this PR the GO Feature Flag provider has been completely rebuilt on top of the OFREP provider.
This implementation adds a bunch of GO Feature Flag features on top of OFREP:
This version contains breaking changes on the configuration struct:
(In order to minimize the dependencies of the GO provider, we have removed the dependency to
thomaspoignant/go-feature-flag
, this means that you can't use the GO module with this provider anymore BUT you can now use the new provider for this feat(go-feature-flag): GO Feature Flag in process using GO module #546).HTTPClient
to use directly*http.Client
.v1.32.0
or more.Related PR
Fixes #546