Skip to content

feat: Implement Multiprovider #668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jblacker wants to merge 60 commits into from
Closed

feat: Implement Multiprovider #668

jblacker wants to merge 60 commits into from

Conversation

@jblacker
Copy link
Contributor

@jblacker jblacker commented Apr 24, 2025

This PR

Adds an implementation of multi-provider for combining multiple providers into a single provider.

Related Issues

Implements #599

Notes

I implemented this based on the JavaScript version of the OpenFeature SDK. More strategies can be added at any time. Additionally, I branched off of @bbland1 so some of their commits are also part of this branch.

Follow-up Tasks

  • Implement Hooks support (although the inner provider's hooks will still be triggered)
  • Implement proper eventing support
  • Finish implementing slog support

How to test

Create multiple FeatureProviders and pass them to the NewMultiProvider method along with a strategy and any options.
Verify the results are as expected based on the strategy.

bbland1 and others added 30 commits March 8, 2025 18:40
@bbland1
feat(multi-provider): set up multi-provider directory
089c098 
Signed-off-by: bbland1 <104288486+bbland1@users.noreply.github.com>
@bbland1
feat: set up func to create new multiprovider & register passed provi…
b8275df 
…ders

Signed-off-by: bbland1 <104288486+bbland1@users.noreply.github.com>
@bbland1
feat: added Metadata Method to the multiprovider
6ef2dd8 
Signed-off-by: bbland1 <104288486+bbland1@users.noreply.github.com>
@bbland1
feat: added the based of the Init method that will process the inital…
63a5300 
…ize of the providers

Signed-off-by: bbland1 <104288486+bbland1@users.noreply.github.com>
@bbland1
moved providers into pkg directory
ac9ab37 
Signed-off-by: bbland1 <104288486+bbland1@users.noreply.github.com>
@bbland1
added Init method to handle any providers with intialization
65e2f04 
Signed-off-by: bbland1 <104288486+bbland1@users.noreply.github.com>
@bbland1
added the Shutdown method
dd933fb 
Signed-off-by: bbland1 <104288486+bbland1@users.noreply.github.com>
@bbland1
added getter methods to the unexported fields
32af790 
Signed-off-by: bbland1 <104288486+bbland1@users.noreply.github.com>
@bbland1
added tests to check unique name for providers passed
c6aaf74 
Signed-off-by: bbland1 <104288486+bbland1@users.noreply.github.com>
@bbland1
added test checking if error thrown for unique name if not unique
70878e5 
Signed-off-by: bbland1 <104288486+bbland1@users.noreply.github.com>
@bbland1
added test to check for metadata, currently fails
d5f3d6a 
Signed-off-by: bbland1 <104288486+bbland1@users.noreply.github.com>
@bbland1
added test for getter methods of the struct provider entries
a3ba348 
Signed-off-by: bbland1 <104288486+bbland1@users.noreply.github.com>
@cupofcat @bbland1
chore(flagd): Updates flagd core to v0.11.2 (open-feature#636)
efa68b9 
Signed-off-by: Maks Osowski <maks@google.com>
Signed-off-by: bbland1 <104288486+bbland1@users.noreply.github.com>
@cupofcat @bbland1
feat(flagd): Added WithGrpcDialOptionsOverride provider option (open-…
0ac6343 
…feature#638)

Signed-off-by: Maks Osowski <maks@google.com>
Signed-off-by: bbland1 <104288486+bbland1@users.noreply.github.com>
@github-actions @bbland1
chore(main): release providers/flagd 0.2.6 (open-feature#635)
270f5e5 
Signed-off-by: OpenFeature Bot <109696520+openfeaturebot@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Signed-off-by: bbland1 <104288486+bbland1@users.noreply.github.com>
@toddbaert @aimuz @bbland1
fix(deps): Remove dependency on sigs.k8s.io/controller-runtime/pkg/lo… (
0067b34 
open-feature#639)

Signed-off-by: aimuz <mr.imuz@gmail.com>
Co-authored-by: aimuz <mr.imuz@gmail.com>
Signed-off-by: bbland1 <104288486+bbland1@users.noreply.github.com>
@thomaspoignant @bbland1
chore(go-feature-flag): Support new hook format (open-feature#641)
4e259c6 
Signed-off-by: Thomas Poignant <thomas.poignant@gofeatureflag.org>
Signed-off-by: bbland1 <104288486+bbland1@users.noreply.github.com>
@github-actions @bbland1
chore(main): release providers/go-feature-flag 0.2.4 (open-feature#643)
e225fbd 
Signed-off-by: OpenFeature Bot <109696520+openfeaturebot@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Signed-off-by: bbland1 <104288486+bbland1@users.noreply.github.com>
@bbland1
added test for MP Init method with mock providers that have Init methods
ac2f314 
Signed-off-by: bbland1 <104288486+bbland1@users.noreply.github.com>
@bbland1
added shutdown test confirming method run in MP when called
2d6f44b 
Signed-off-by: bbland1 <104288486+bbland1@users.noreply.github.com>
@bbland1
added the empty bases of the evaluations and hooks methods
11abc28 
Signed-off-by: bbland1 <104288486+bbland1@users.noreply.github.com>
@bbland1
added test for init errors by a provider and reduced the mock provide…
1939205 
…r struct made

Signed-off-by: bbland1 <104288486+bbland1@users.noreply.github.com>
@bbland1
removed memprovider since NewTestProvider uses it
fede2c6 
Signed-off-by: bbland1 <104288486+bbland1@users.noreply.github.com>
@bbland1
added metadata aggregate to the method and updated test to properly use
9a96d94 
Signed-off-by: bbland1 <104288486+bbland1@users.noreply.github.com>
@bbland1
added ready and error state to the init method for the multi provider
9b5c8e6 
Signed-off-by: bbland1 <104288486+bbland1@users.noreply.github.com>
@bbland1
added a func to determine which eval strategy to use and added it to …
cbdbcc3 
…where it should be when strategies pushed

Signed-off-by: bbland1 <104288486+bbland1@users.noreply.github.com>
@bbland1
creating the base of a base strategy similar to js version that can b…
28efb9f 
…e used to define custom strategies

Signed-off-by: bbland1 <104288486+bbland1@users.noreply.github.com>
@bbland1
fleshing out the BaseStrategy to have the help funcs to be used in st…
e52cd9c 
…rategies similar to TS and passing that type into the provider

Signed-off-by: bbland1 <104288486+bbland1@users.noreply.github.com>
@github-actions @jblacker
chore(main): release providers/configcat 0.2.2 (open-feature#458)
76b3e4d 
Signed-off-by: OpenFeature Bot <109696520+openfeaturebot@users.noreply.github.com>
@raphael-wigoutschnigg-dt @jblacker
feat(flagd)!: add file mode to flagd provider (open-feature#648)
5a9602f 
Signed-off-by: Raphael Wigoutschnigg <raphael.wigoutschnigg@dynatrace.com>
jblacker added 24 commits April 23, 2025 21:34
@jblacker
feat: Add FirstSuccessStrategy Implementation
a3fa498 
Signed-off-by: Jordan Blacker <jblacker@justworks.com>
@jblacker
doc: Add README for multiprovider
b78bed0 
Signed-off-by: Jordan Blacker <jblacker@justworks.com>
@jblacker
feat: Configure strategy in provider initializer
78c9fd1 
Signed-off-by: Jordan Blacker <jblacker@justworks.com>
@jblacker
feat: wire it all up
fe42a63 
Signed-off-by: Jordan Blacker <jblacker@justworks.com>
@jblacker
refactor: use strategy's own name
6c7f086 
Signed-off-by: Jordan Blacker <jblacker@justworks.com>
@jblacker
fix: handle post-rebase conflicts
61662f0 
Signed-off-by: Jordan Blacker <jblacker@justworks.com>
@jblacker
refactor: Rename types, reorganize package structure
97e031e 
- Rename UniqueNameProvider -> NamedProvider: More accurate description of type as it's not enforced
- Updated signature of NewMultiProvider function: Using a map enforces unique names, use options pattern & config object for future extension
- Relocated NamedProvider to strategies as it's not needed externally
- Update shape of MultiProvider: Added logging, made all fields private, used map internally
- Moved aggregate-errors into errors package
- Added alias for ProviderMap shape & added helper functions
- Use pointers since we're passing stuff around and want to avoid unnecessary clones of objects & extra garbage collection
- Updated other various signatures throughout as needed
- Update tests & remove tests that no longer apply

Signed-off-by: Jordan Blacker <jblacker@justworks.com>
@jblacker
doc: Update README
3acfde9 
Signed-off-by: Jordan Blacker <jblacker@justworks.com>
@jblacker
cleanup: Remove unused public strategy package
045e711 
Signed-off-by: Jordan Blacker <jblacker@justworks.com>
@jblacker
fix: correct test names for first_success_test
edd9d27 
Signed-off-by: Jordan Blacker <jblacker@justworks.com>
@jblacker
feat: implement comparison strategy
7953ad3 
Signed-off-by: Jordan Blacker <jblacker@justworks.com>
@jblacker
fix: Patch bug where metadata would not be generated in a stable way
b073a38 
Signed-off-by: Jordan Blacker <jblacker@justworks.com>
@jblacker
refactor: Move options to new file
0b75120 
Signed-off-by: Jordan Blacker <jblacker@justworks.com>
@jblacker
refactor: Rewrite aggregate errors & simplify Init method
786a72b 
Also fixed some synchronization issues while I was at it

Signed-off-by: Jordan Blacker <jblacker@justworks.com>
@jblacker
fix: Correct broken cleanErrorMessage helper func
f04376f 
Signed-off-by: Jordan Blacker <jblacker@justworks.com>
@jblacker
feat: Add tag merge helper method
bac75aa 
Signed-off-by: Jordan Blacker <jblacker@justworks.com>
@jblacker
refactor: Move mock file to mocks package
4f35403 
Signed-off-by: Jordan Blacker <jblacker@justworks.com>
@jblacker
refactor: Rewrite first success implementation to be more go-y
5c520f3 
- Rewrote using multiple go-routines & channels instead of a mutex
- Added tests
- Added timeout functionality & option

Signed-off-by: Jordan Blacker <jblacker@justworks.com>
@jblacker
fix: correct bug in default resolution func
f3beba1 
Signed-off-by: Jordan Blacker <jblacker@justworks.com>
@jblacker
refactor: Use evaluator for first_match
99a2b1d 
Signed-off-by: Jordan Blacker <jblacker@justworks.com>
@jblacker
refactor: Rename test helper
58b629d 
Signed-off-by: Jordan Blacker <jblacker@justworks.com>
@jblacker
refactor: Alias package to prevent shadowing
07d9b9c 
Signed-off-by: Jordan Blacker <jblacker@justworks.com>
@jblacker
refactor: Modify comparison implementation with comp functions
0a686a3 
Signed-off-by: Jordan Blacker <jblacker@justworks.com>
@jblacker
doc: Update README
ff0f81f 
Signed-off-by: Jordan Blacker <jblacker@justworks.com>
@jblacker jblacker force-pushed the 599/implement-multi-provider branch from c61f457 to ff0f81f Compare April 24, 2025 01:34
@bbland1 bbland1 mentioned this pull request Apr 24, 2025
Closed
@jblacker jblacker mentioned this pull request Apr 24, 2025
Merged
@jblacker
Copy link
Contributor Author

jblacker commented Apr 24, 2025

Closing due to the branch being screwy. Reopened as #669

@jblacker jblacker closed this Apr 24, 2025
@jblacker jblacker deleted the 599/implement-multi-provider branch April 24, 2025 02:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bacherfl bacherfl Awaiting requested review from bacherfl

@gagantrivedi gagantrivedi Awaiting requested review from gagantrivedi

@Kavindu-Dodan Kavindu-Dodan Awaiting requested review from Kavindu-Dodan

@matthewelwell matthewelwell Awaiting requested review from matthewelwell

@rcrowe rcrowe Awaiting requested review from rcrowe

@thomaspoignant thomaspoignant Awaiting requested review from thomaspoignant

@toddbaert toddbaert Awaiting requested review from toddbaert

@z4kn4fein z4kn4fein Awaiting requested review from z4kn4fein

Assignees

@rcrowe rcrowe

@bacherfl bacherfl

@Kavindu-Dodan Kavindu-Dodan

@z4kn4fein z4kn4fein

@matthewelwell matthewelwell

@thomaspoignant thomaspoignant

@gagantrivedi gagantrivedi

@toddbaert toddbaert

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.