Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: events for go sdk #187

Closed
wants to merge 26 commits into from

Conversation

Kavindu-Dodan
Copy link
Contributor

@Kavindu-Dodan Kavindu-Dodan commented Jun 16, 2023

@codecov
Copy link

codecov bot commented Jun 16, 2023

Codecov Report

Merging #187 (1830f83) into main (609af46) will increase coverage by 3.33%.
The diff coverage is 88.88%.

@@            Coverage Diff             @@
##             main     #187      +/-   ##
==========================================
+ Coverage   72.97%   76.31%   +3.33%     
==========================================
  Files           8        9       +1     
  Lines         766      971     +205     
==========================================
+ Hits          559      741     +182     
- Misses        187      207      +20     
- Partials       20       23       +3     
Impacted Files Coverage Δ
pkg/openfeature/provider.go 68.00% <0.00%> (-32.00%) ⬇️
pkg/openfeature/api.go 90.35% <66.66%> (-4.55%) ⬇️
pkg/openfeature/openfeature.go 97.67% <93.33%> (-2.33%) ⬇️
pkg/openfeature/event_handler.go 95.06% <95.06%> (ø)
pkg/openfeature/client.go 70.44% <100.00%> (+0.24%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Kavindu-Dodan Kavindu-Dodan force-pushed the feat/events branch 2 times, most recently from af99356 to ef44e98 Compare June 16, 2023 22:04
Signed-off-by: Kavindu Dodanduwa <kavindudodanduwa@gmail.com>
Signed-off-by: Kavindu Dodanduwa <kavindudodanduwa@gmail.com>
Signed-off-by: Kavindu Dodanduwa <kavindudodanduwa@gmail.com>
Signed-off-by: Kavindu Dodanduwa <kavindudodanduwa@gmail.com>
Signed-off-by: Kavindu Dodanduwa <kavindudodanduwa@gmail.com>
Signed-off-by: Kavindu Dodanduwa <kavindudodanduwa@gmail.com>
Signed-off-by: Kavindu Dodanduwa <kavindudodanduwa@gmail.com>
Signed-off-by: Kavindu Dodanduwa <kavindudodanduwa@gmail.com>
Signed-off-by: Kavindu Dodanduwa <kavindudodanduwa@gmail.com>
Signed-off-by: Kavindu Dodanduwa <kavindudodanduwa@gmail.com>
Signed-off-by: Kavindu Dodanduwa <kavindudodanduwa@gmail.com>
Signed-off-by: Kavindu Dodanduwa <kavindudodanduwa@gmail.com>
Signed-off-by: Kavindu Dodanduwa <kavindudodanduwa@gmail.com>
Signed-off-by: Kavindu Dodanduwa <kavindudodanduwa@gmail.com>
Signed-off-by: Kavindu Dodanduwa <kavindudodanduwa@gmail.com>
Signed-off-by: Kavindu Dodanduwa <kavindudodanduwa@gmail.com>
Signed-off-by: Kavindu Dodanduwa <kavindudodanduwa@gmail.com>
Signed-off-by: Kavindu Dodanduwa <kavindudodanduwa@gmail.com>
Signed-off-by: Kavindu Dodanduwa <kavindudodanduwa@gmail.com>
Signed-off-by: Kavindu Dodanduwa <kavindudodanduwa@gmail.com>
Signed-off-by: Kavindu Dodanduwa <kavindudodanduwa@gmail.com>
# Conflicts:
#	pkg/openfeature/openfeature_test.go
#	pkg/openfeature/provider.go
Signed-off-by: Kavindu Dodanduwa <kavindudodanduwa@gmail.com>
Signed-off-by: Kavindu Dodanduwa <kavindudodanduwa@gmail.com>
Signed-off-by: Kavindu Dodanduwa <kavindudodanduwa@gmail.com>
# Conflicts:
#	pkg/openfeature/api.go
#	pkg/openfeature/openfeature.go
#	pkg/openfeature/openfeature_test.go
#	pkg/openfeature/provider.go
#	pkg/openfeature/provider_mock_test.go
#	pkg/openfeature/util_test.go
@Kavindu-Dodan Kavindu-Dodan marked this pull request as ready for review June 20, 2023 21:21
@Kavindu-Dodan Kavindu-Dodan requested a review from a team as a code owner June 20, 2023 21:21
@Kavindu-Dodan
Copy link
Contributor Author

closing in-favor of #188

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement event support
1 participant