Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: go feature flags: use sdk functionality #403

Merged
merged 6 commits into from
Sep 6, 2023
Merged

chore: go feature flags: use sdk functionality #403

merged 6 commits into from
Sep 6, 2023

Conversation

liran2000
Copy link
Member

@liran2000 liran2000 commented Aug 17, 2023 •
edited
Loading

This PR

  • use recently added sdk functionality instead of each provider implementation.
  • issue 405 - missing targeting key

@liran2000
chore: use framework functionality
607b822 
Signed-off-by: liran2000 <liran2000@gmail.com>
@liran2000 liran2000 requested a review from a team as a code owner August 17, 2023 09:12
@liran2000
Copy link
Member Author

@thomaspoignant to review when available.

@toddbaert to see how some recent SDK functionality can help providers by using it instead of needing to implement for each provider.

@github-actions github-actions bot mentioned this pull request Aug 19, 2023
Closed
Kavindu-Dodan
Kavindu-Dodan previously approved these changes Aug 21, 2023
View reviewed changes
@Kavindu-Dodan Kavindu-Dodan dismissed their stale review August 21, 2023 19:53

concerns over usage pattern

@liran2000
chore: use framework functionality - enrich test
432a712 
Signed-off-by: liran2000 <liran2000@gmail.com>
@liran2000
fix: issue 405 - missing targeting key
f540cd1 
return TARGETING_KEY_MISSING error code when relevant

Signed-off-by: liran2000 <liran2000@gmail.com>
@liran2000 liran2000 mentioned this pull request Aug 24, 2023
Closed
thomaspoignant
thomaspoignant approved these changes Sep 5, 2023
View reviewed changes
Copy link
Member

@thomaspoignant thomaspoignant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super nice contribution, thanks a lot this makes the code way more readable.

...lag/src/main/java/dev/openfeature/contrib/providers/gofeatureflag/GoFeatureFlagProvider.java Show resolved Hide resolved
...src/test/java/dev/openfeature/contrib/providers/gofeatureflag/GoFeatureFlagProviderTest.java Outdated Show resolved Hide resolved
@liran2000
Copy link
Member Author

@toddbaert can this be merged?

@thomaspoignant thomaspoignant merged commit 81fc412 into open-feature:main Sep 6, 2023
4 checks passed
@thomaspoignant
Copy link
Member

@liran2000 I've merged it, thanks a lot again for your contribution 🙏

@liran2000 liran2000 deleted the go-ff-provider-update branch September 6, 2023 16:30
Kavindu-Dodan pushed a commit to Kavindu-Dodan/java-sdk-contrib that referenced this pull request Sep 6, 2023
@liran2000 @Kavindu-Dodan
chore: go feature flags: use sdk functionality (open-feature#403)
d805b93 
Signed-off-by: liran2000 <liran2000@gmail.com>
DBlanchard88 pushed a commit to DBlanchard88/java-sdk-contrib that referenced this pull request Apr 29, 2024
@renovate
chore(deps): update dependency org.apache.maven.plugins:maven-checkst…
311b73f 
…yle-plugin to v3.2.2 (open-feature#403)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kavindu-Dodan Kavindu-Dodan Kavindu-Dodan left review comments

@thomaspoignant thomaspoignant thomaspoignant approved these changes

Assignees

@thomaspoignant thomaspoignant

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@liran2000 @thomaspoignant @Kavindu-Dodan