feat!: context enrichment via contextEnricher, not from init #991
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
beeme1mr,
Kavindu-Dodan and
thisthat
toddbaert
changed the title
toddbaert
commented
Sep 30, 2024
| * SyncMetadata. | ||
| * Set on initial connection and updated with every reconnection. | ||
| * see: | ||
| * https://buf.build/open-feature/flagd/docs/main:flagd.sync.v1#flagd.sync.v1.FlagSyncService.GetMetadata | ||
| * | ||
| * @return Object map representing sync metadata | ||
| */ | ||
| protected Map<String, Object> getSyncMetadata() { | ||
| return Collections.unmodifiableMap(syncMetadata); | ||
| protected Structure getSyncMetadata() { |
There was a problem hiding this comment.
This is a much safer type which we already use for this sort of thing.
toddbaert
commented
Sep 30, 2024
| @@ -149,6 +158,7 @@ private void onConnectionEvent(ConnectionEvent connectionEvent) { | |||
| boolean previous = connected; | |||
| boolean current = connected = connectionEvent.isConnected(); | |||
| syncMetadata = connectionEvent.getSyncMetadata(); | |||
| enrichedContext = contextEnricher.apply(connectionEvent.getSyncMetadata()); | |||
There was a problem hiding this comment.
Every time the resolver connects, we update the cached context by re-running the passed enricher.
toddbaert
commented
Sep 30, 2024
| @@ -177,6 +177,12 @@ By default, the provider is configured to | |||
| use [least recently used (lru)](https://commons.apache.org/proper/commons-collections/apidocs/org/apache/commons/collections4/map/LRUMap.html) | |||
| caching with up to 1000 entries. | |||
|
|
|||
| ##### Context enrichment | |||
There was a problem hiding this comment.
This can be used to select a subset of fields from the getMetadata response. By default, all of it is injected into the context.
toddbaert
commented
Sep 30, 2024
toddbaert
commented
Sep 30, 2024
aepfli
reviewed
Oct 1, 2024
providers/flagd/src/main/java/dev/openfeature/contrib/providers/flagd/SyncMetadataHook.java
Outdated
Show resolved
Hide resolved
toddbaert
commented
Oct 1, 2024
providers/flagd/src/main/java/dev/openfeature/contrib/providers/flagd/SyncMetadataHook.java
Outdated
Show resolved
Hide resolved
toddbaert
force-pushed
the
feat/sync-metadata
branch
2 times, most recently
from
ffa1893 to
faa9e80
Compare
aepfli
approved these changes
Oct 2, 2024
Signed-off-by: Todd Baert <todd.baert@dynatrace.com>
Signed-off-by: Todd Baert <todd.baert@dynatrace.com>
Signed-off-by: Todd Baert <todd.baert@dynatrace.com>
…s/flagd/SyncMetadataHook.java Signed-off-by: Todd Baert <todd.baert@dynatrace.com>
toddbaert
force-pushed
the
feat/sync-metadata
branch
from
faa9e80 to
20300ab
Compare
Signed-off-by: Todd Baert <todd.baert@dynatrace.com>
beeme1mr
approved these changes
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
contextEnricheroption added which does the above, and moreContinuation of #967.